From: Jonas Ã…dahl Date: Tue, 31 Mar 2020 17:00:58 +0000 (+0200) Subject: appDisplay: Clear animateLater callbacks when unmapping X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~684^2^2~562 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=f49b58cf97e167dca74b902fe1bf21d296495113;p=gnome-shell.git appDisplay: Clear animateLater callbacks when unmapping In some situations we could end up not with lingering 'view-loaded' handler. This could result in delayed spring animate-in being initiated, e.g. after a minute after the activities overview was already closed. Fix this by removing any lingering signal or later handlers when unmapping. Fixes: 5c33fe4a0a4eb4ed https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1155 --- diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js index 4ba4ed67c..e07769caa 100644 --- a/js/ui/appDisplay.js +++ b/js/ui/appDisplay.js @@ -291,6 +291,11 @@ var BaseAppView = GObject.registerClass({ } } + vfunc_unmap() { + this._clearAnimateLater(); + super.vfunc_unmap(); + } + animateSwitch(animationDirection) { this.remove_all_transitions(); this._grid.remove_all_transitions();